From: Jakub Vrana <jakub@vrana.cz>
Date: Mon, 11 Nov 2019 11:23:41 +0000 (+0100)
Subject: Add id="" to cells with failed inline edit (bug #708)
X-Git-Tag: v4.7.5~10
X-Git-Url: https://git.joonet.de/?a=commitdiff_plain;h=c24dd79c22cdaa35d0752fe8f272252d554573dd;p=adminer.git

Add id="" to cells with failed inline edit (bug #708)
---

diff --git a/adminer/select.inc.php b/adminer/select.inc.php
index 403e0453..2ea056a9 100644
--- a/adminer/select.inc.php
+++ b/adminer/select.inc.php
@@ -436,12 +436,13 @@ if (!$columns && support("table")) {
 						$value = $_POST["val"][$unique_idf][bracket_escape($key)];
 						$editable = !is_array($row[$key]) && is_utf8($val) && $rows[$n][$key] == $row[$key] && !$functions[$key];
 						$text = preg_match('~text|lob~', $field["type"]);
+						echo "<td id='$id'";
 						if (($_GET["modify"] && $editable) || $value !== null) {
 							$h_value = h($value !== null ? $value : $row[$key]);
-							echo "<td>" . ($text ? "<textarea name='$id' cols='30' rows='" . (substr_count($row[$key], "\n") + 1) . "'>$h_value</textarea>" : "<input name='$id' value='$h_value' size='$lengths[$key]'>");
+							echo ">" . ($text ? "<textarea name='$id' cols='30' rows='" . (substr_count($row[$key], "\n") + 1) . "'>$h_value</textarea>" : "<input name='$id' value='$h_value' size='$lengths[$key]'>");
 						} else {
 							$long = strpos($val, "<i>…</i>");
-							echo "<td id='$id' data-text='" . ($long ? 2 : ($text ? 1 : 0)) . "'"
+							echo " data-text='" . ($long ? 2 : ($text ? 1 : 0)) . "'"
 								. ($editable ? "" : " data-warning='" . h(lang('Use edit link to modify this value.')) . "'")
 								. ">$val</td>"
 							;
diff --git a/changes.txt b/changes.txt
index 15207441..89d0ca68 100644
--- a/changes.txt
+++ b/changes.txt
@@ -1,4 +1,5 @@
 Adminer 4.7.5-dev:
+Add id="" to cells with failed inline edit (bug #708)
 PostgreSQL, Oracle: Set schema for EXPLAIN queries in SQL command (bug #706)
 
 Adminer 4.7.4 (released 2019-10-22):