Improve limit check in edit-foreign plugin

The limit is enforced in the query to prevent out-of-memory errors for big target tables.

diff --git a/plugins/edit-foreign.php b/plugins/edit-foreign.php
index 0bb825a2efb29f028edfa1e4eec40b4225fa0f39..0b5227c69b50e138d69614d119147326068e1b65 100644 (file)
--- a/plugins/edit-foreign.php
+++ b/plugins/edit-foreign.php
@@ -30,7 +30,7 @@ class AdminerEditForeign {
                                        if (preg_match('~binary~', $field["type"])) {
                                                $column = "HEX($column)";
                                        }
-                                       $options = array("" => "") + get_vals("SELECT $column FROM " . table($target) . " ORDER BY 1");
+                                       $options = array("" => "") + get_vals("SELECT $column FROM " . table($target) . " ORDER BY 1" . ($this->_limit ? " LIMIT " . ($this->_limit + 1) : ""));
                                        if ($this->_limit && count($options) - 1 > $this->_limit) {
                                                return;
                                        }