Add id="" to cells with failed inline edit (bug #708)

diff --git a/adminer/select.inc.php b/adminer/select.inc.php
index 403e04539a6d7cef062ca20516d92be66506b622..2ea056a9c45fa0a2b8f5cf057f07c9de20a75815 100644 (file)
--- a/adminer/select.inc.php
+++ b/adminer/select.inc.php
@@ -436,12 +436,13 @@ if (!$columns && support("table")) {
                                                $value = $_POST["val"][$unique_idf][bracket_escape($key)];
                                                $editable = !is_array($row[$key]) && is_utf8($val) && $rows[$n][$key] == $row[$key] && !$functions[$key];
                                                $text = preg_match('~text|lob~', $field["type"]);
+                                               echo "<td id='$id'";
                                                if (($_GET["modify"] && $editable) || $value !== null) {
                                                        $h_value = h($value !== null ? $value : $row[$key]);
-                                                       echo "<td>" . ($text ? "<textarea name='$id' cols='30' rows='" . (substr_count($row[$key], "\n") + 1) . "'>$h_value</textarea>" : "<input name='$id' value='$h_value' size='$lengths[$key]'>");
+                                                       echo ">" . ($text ? "<textarea name='$id' cols='30' rows='" . (substr_count($row[$key], "\n") + 1) . "'>$h_value</textarea>" : "<input name='$id' value='$h_value' size='$lengths[$key]'>");
                                                } else {
                                                        $long = strpos($val, "<i>…</i>");
-                                                       echo "<td id='$id' data-text='" . ($long ? 2 : ($text ? 1 : 0)) . "'"
+                                                       echo " data-text='" . ($long ? 2 : ($text ? 1 : 0)) . "'"
                                                                . ($editable ? "" : " data-warning='" . h(lang('Use edit link to modify this value.')) . "'")
                                                                . ">$val</td>"
                                                        ;

diff --git a/changes.txt b/changes.txt
index 15207441e623d67ea057cd614425644e7faabf98..89d0ca6891e7cb62f1810480f274b9aaabc422dc 100644 (file)
--- a/changes.txt
+++ b/changes.txt
@@ -1,4 +1,5 @@
 Adminer 4.7.5-dev:
+Add id="" to cells with failed inline edit (bug #708)
 PostgreSQL, Oracle: Set schema for EXPLAIN queries in SQL command (bug #706)
 
 Adminer 4.7.4 (released 2019-10-22):