Avoid qsl in a loop

diff --git a/adminer/dump.inc.php b/adminer/dump.inc.php
index 4df94f9b013967e2c2b5938c081fc2772cafee39..30a2a45ee2f6aef6a73599dc59c0f739214eef66 100644 (file)
--- a/adminer/dump.inc.php
+++ b/adminer/dump.inc.php
@@ -179,11 +179,11 @@ if (DB != "") {
        foreach ($tables_list as $name => $type) {
                $prefix = preg_replace('~_.*~', '', $name);
                $checked = ($TABLE == "" || $TABLE == (substr($TABLE, -1) == "%" ? "$prefix%" : $name)); //! % may be part of table name
-               $print = "<tr><td>" . checkbox("tables[]", $name, $checked, $name, "formUncheck('check-tables');", "block");
+               $print = "<tr><td>" . checkbox("tables[]", $name, $checked, $name, "", "block");
                if ($type !== null && !preg_match('~table~i', $type)) {
                        $views .= "$print\n";
                } else {
-                       echo "$print<td align='right'><label class='block'><span id='Rows-" . h($name) . "'></span>" . checkbox("data[]", $name, $checked, "", "formUncheck('check-data');") . "</label>\n";
+                       echo "$print<td align='right'><label class='block'><span id='Rows-" . h($name) . "'></span>" . checkbox("data[]", $name, $checked) . "</label>\n";
                }
                $prefixes[$prefix]++;
        }
@@ -203,7 +203,7 @@ if (DB != "") {
                foreach ($databases as $db) {
                        if (!information_schema($db)) {
                                $prefix = preg_replace('~_.*~', '', $db);
-                               echo "<tr><td>" . checkbox("databases[]", $db, $TABLE == "" || $TABLE == "$prefix%", $db, "formUncheck('check-databases');", "block") . "\n";
+                               echo "<tr><td>" . checkbox("databases[]", $db, $TABLE == "" || $TABLE == "$prefix%", $db, "", "block") . "\n";
                                $prefixes[$prefix]++;
                        }
                }

diff --git a/adminer/static/editing.js b/adminer/static/editing.js
index 6e42cfe3bacaf1ac64b7dbb1571c05ddc7e6fb3d..8f4c4b139cd94fabf817efb3ea138f0dfc373557 100644 (file)
--- a/adminer/static/editing.js
+++ b/adminer/static/editing.js
@@ -411,7 +411,12 @@ function partitionNameChange() {
 function dumpClick(event) {
        var el = parentTag(getTarget(event), 'label');
        if (el) {
-               checkboxClick.call(el.firstChild, event);
+               el = qs('input', el);
+               var match = /(.+)\[\]$/.exec(el.name);
+               if (match) {
+                       checkboxClick.call(el, event);
+                       formUncheck('check-' + match[1]);
+               }
        }
 }