Comments

git-svn-id: https://adminer.svn.sourceforge.net/svnroot/adminer/trunk@807 7c3ca157-0c34-0410-bff1-cbf682f78f5c

diff --git a/adminer/select.inc.php b/adminer/select.inc.php
index 6c1c20491b1bac3b8373df168af8dd255680ae4b..52427d2c344d76db86c8769c93fa1bfedbb10803 100644 (file)
--- a/adminer/select.inc.php
+++ b/adminer/select.inc.php
@@ -273,13 +273,13 @@ if (!$columns) {
                                        }
                                        if (!isset($val)) {
                                                $val = "<i>NULL</i>";
-                                       } elseif (preg_match('~blob|binary~', $fields[$key]["type"]) && !is_utf8($val)) {
+                                       } elseif (preg_match('~blob|binary~', $fields[$key]["type"]) && !is_utf8($val)) { //! download link may be printed even with is_utf8
                                                $val = '<a href="' . htmlspecialchars($SELF) . 'download=' . urlencode($_GET["select"]) . '&amp;field=' . urlencode($key) . '&amp;' . $unique_idf . '">' . lang('%d byte(s)', strlen($val)) . '</a>';
                                        } else {
                                                if (!strlen(trim($val, " \t"))) {
                                                        $val = "&nbsp;";
                                                } elseif (intval($text_length) > 0 && preg_match('~blob|text~', $fields[$key]["type"])) {
-                                                       $val = nl2br(shorten_utf8($val, intval($text_length)));
+                                                       $val = nl2br(shorten_utf8($val, intval($text_length))); // usage of LEFT() would reduce traffic but complicates query
                                                } else {
                                                        $val = nl2br(htmlspecialchars($val));
                                                        if ($fields[$key]["type"] == "char") {