Return false from editingRemoveRow

diff --git a/adminer/include/editing.inc.php b/adminer/include/editing.inc.php
index 8a6e4458ee242ea79982645eb019c214756f28d9..4cae2c7050972469364b29e0ae9dc7ac9a377531 100644 (file)
--- a/adminer/include/editing.inc.php
+++ b/adminer/include/editing.inc.php
@@ -280,7 +280,7 @@ echo checkbox("fields[$i][has_default]", 1, $field["has_default"], "", "", "", "
                        . "<input type='image' class='icon' name='up[$i]' src='../adminer/static/up.gif' alt='^' title='" . lang('Move up') . "' onclick='return !editingMoveRow.call(this, 1);'>&nbsp;"
                        . "<input type='image' class='icon' name='down[$i]' src='../adminer/static/down.gif' alt='v' title='" . lang('Move down') . "' onclick='return !editingMoveRow.call(this, 0);'>&nbsp;"
                : "");
-               echo ($orig == "" || support("drop_col") ? "<input type='image' class='icon' name='drop_col[$i]' src='../adminer/static/cross.gif' alt='x' title='" . lang('Remove') . "' onclick=\"return !editingRemoveRow.call(this, 'fields\$1[field]');\">" : "");
+               echo ($orig == "" || support("drop_col") ? "<input type='image' class='icon' name='drop_col[$i]' src='../adminer/static/cross.gif' alt='x' title='" . lang('Remove') . "' onclick=\"return editingRemoveRow.call(this, 'fields\$1[field]');\">" : "");
                echo "\n";
        }
 }

diff --git a/adminer/indexes.inc.php b/adminer/indexes.inc.php
index da82ff21b3383e8b3c7a2dc8f1852bb63789d2c3..345123473c2038f3f1dd2ab29a92ec096965eba8 100644 (file)
--- a/adminer/indexes.inc.php
+++ b/adminer/indexes.inc.php
@@ -132,7 +132,7 @@ foreach ($row["indexes"] as $index) {
                }
 
                echo "<td><input name='indexes[$j][name]' value='" . h($index["name"]) . "' autocapitalize='off' aria-labelledby='label-name'>\n";
-               echo "<td><input type='image' class='icon' name='drop_col[$j]' src='../adminer/static/cross.gif' alt='x' title='" . lang('Remove') . "' onclick=\"return !editingRemoveRow.call(this, 'indexes\$1[type]');\">\n";
+               echo "<td><input type='image' class='icon' name='drop_col[$j]' src='../adminer/static/cross.gif' alt='x' title='" . lang('Remove') . "' onclick=\"return editingRemoveRow.call(this, 'indexes\$1[type]');\">\n";
        }
        $j++;
 }

diff --git a/adminer/static/editing.js b/adminer/static/editing.js
index e7cfbd48f3e947c680479aa56ea1ddce848d6aa9..1cdafc2c448f9d5f61e161e032e0218cb2383c5d 100644 (file)
--- a/adminer/static/editing.js
+++ b/adminer/static/editing.js
@@ -258,14 +258,14 @@ function editingAddRow(focus) {
 
 /** Remove table row for field
 * @param string
-* @return boolean
+* @return boolean false
 * @this HTMLInputElement
 */
 function editingRemoveRow(name) {
        var field = formField(this.form, this.name.replace(/[^\[]+(.+)/, name));
        field.parentNode.removeChild(field);
        parentTag(this, 'tr').style.display = 'none';
-       return true;
+       return false;
 }
 
 /** Move table row for field